Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves a private issue sent to me on slack
Summary*
Array map is a fairly old method written before we had
std::mem::zeroed. Now that we have zeroed, we can allow mapping empty arrays since we can usezeroedto get the fillerUvalue for the starting elements.Additional Context
While I was at it I included a small clarification to
reduce's docs that it requires a non-empty arrayDocumentation*
Check one:
PR Checklist*
cargo fmton default settings.